feat: added Get/Set Environment on Scope#5772
Open
bitsandfoxes wants to merge 4 commits into
Open
Conversation
Contributor
|
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b193867 | 331.08 ms | 397.06 ms | 65.98 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| 22ff2c7 | 306.60 ms | 336.65 ms | 30.05 ms |
| a5ab36f | 320.47 ms | 389.77 ms | 69.30 ms |
| 539ca63 | 313.51 ms | 355.43 ms | 41.92 ms |
| dba088c | 365.46 ms | 366.31 ms | 0.85 ms |
| 4e3e79d | 312.02 ms | 376.24 ms | 64.22 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| ad8da22 | 314.38 ms | 352.29 ms | 37.91 ms |
| bb0ff41 | 344.70 ms | 413.82 ms | 69.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b193867 | 1.58 MiB | 2.19 MiB | 620.00 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 22ff2c7 | 0 B | 0 B | 0 B |
| a5ab36f | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| 539ca63 | 1.58 MiB | 2.12 MiB | 551.41 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 4e3e79d | 0 B | 0 B | 0 B |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| ad8da22 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| bb0ff41 | 0 B | 0 B | 0 B |
…nment # Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/ApplicationExitInfoEventProcessor.java # sentry-android-core/src/test/java/io/sentry/android/core/ApplicationExitInfoEventProcessorTest.kt
bitsandfoxes
marked this pull request as ready for review
July 17, 2026 13:17
bitsandfoxes
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
July 17, 2026 13:17
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f3b38ec. Configure here.
| observer.setEnvironment(environment); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Scope clear omits environment
Medium Severity
Scope.clear() resets fields like level but leaves the new environment field untouched, so a cleared scope can still apply a stale environment to events via applyScope and outrank SentryOptions defaults.
Reviewed by Cursor Bugbot for commit f3b38ec. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds a getter and setter to the scope that allows users to configure the
Environmentat runtime.💡 Motivation and Context
See #5769
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps